Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the Windows docs #573

Merged
merged 8 commits into from May 3, 2023
Merged

Conversation

tangdouer1005
Copy link
Contributor

修改了mogan\docs\zh\guide\Develop_on_Windows.md和mogan\docs\guide\Develop_on_Windows.md

docs/guide/Develop_on_Windows.md Outdated Show resolved Hide resolved
docs/guide/Develop_on_Windows.md Outdated Show resolved Hide resolved
docs/guide/Develop_on_Windows.md Outdated Show resolved Hide resolved
docs/zh/guide/Develop_on_Windows.md Outdated Show resolved Hide resolved
@da-liii da-liii self-requested a review April 17, 2023 11:44
Copy link
Contributor

@jingkaimori jingkaimori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意汉语语病以及标点符号,还有Qt的拼写。

docs/zh/guide/Develop_on_Windows.md Outdated Show resolved Hide resolved
@da-liii
Copy link
Contributor

da-liii commented Apr 17, 2023

mingw -> MinGW

docs/zh/guide/Develop_on_Windows.md Outdated Show resolved Hide resolved
docs/zh/guide/Develop_on_Windows.md Outdated Show resolved Hide resolved
@da-liii
Copy link
Contributor

da-liii commented Apr 17, 2023

Besides the grammar of the documentation, we must verify it on Windows. Before, the dev guide is concise. We do not need to verify it on Windows. Now, it is in detail, we have to make sure it will not waste other people's time.

@da-liii da-liii added the SoC Summer of Code label Apr 19, 2023
@tangdouer1005 tangdouer1005 marked this pull request as draft April 25, 2023 08:34
@tangdouer1005 tangdouer1005 marked this pull request as ready for review May 3, 2023 12:13
@da-liii da-liii merged commit a902fe0 into XmacsLabs:main May 3, 2023
da-liii pushed a commit that referenced this pull request May 3, 2023
修改了mogan\docs\zh\guide\Develop_on_Windows.md和mogan\docs\guide\Develop_on_Windows.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SoC Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants