-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with Game
and Puzzle
datasets
#32
Conversation
Reviewer's Guide by SourceryThis pull request integrates the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Xmaster6y - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 4 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Closes #31
Summary by Sourcery
This pull request integrates the
Game
andPuzzle
datasets, introduces new classes for handling chess puzzles and random sampling, and adds scripts for dataset generation. It also includes refactoring of existing classes and new unit tests to ensure functionality.Puzzle
class with methods for parsing and evaluating chess puzzles.RandomSampler
class for generating random moves in chess games.Game
class to include class methods for dictionary conversion and board state generation.Sampler
class with new methods for utility calculation and move selection.RandomSampler
class.Puzzle
class to validate puzzle evaluation.__init__.py
to include the newpuzzle
module.