Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(s) Request #3

Closed
Haejien opened this issue Mar 6, 2017 · 10 comments
Closed

Feature(s) Request #3

Haejien opened this issue Mar 6, 2017 · 10 comments
Assignees

Comments

@Haejien
Copy link

Haejien commented Mar 6, 2017

Here's a few features that would be extremely useful down the road:

I assume this one was already planned, but just to have it down on paper
Also with this it would be cool to be able to set a flag that would allow you to download more than one episode at once, however I don't know how crunchyroll handles multiple threads so maybe this isn't feasible

  • Merge subtitles and video file into mkv

Maybe even take it a step further and properly set the language for each file in the mkv container

  • Cache site login details/token

Once again I'm not too sure how the token works so if it expires then this probably wouldn't work.

@Xonshiz
Copy link
Owner

Xonshiz commented Mar 7, 2017

Hey,

  • Whole series downloading is supported in this tool. But, that version is available on my patreon only (for a week or so). After a week or so, I'll port that functionality here. I didn't understand this part
Also with this it would be cool to be able to set a flag that would allow you to download more than one episode at once

Do you mean that you want the script to download episodes simultaneously? If yes, I think that it'll be a bad idea. Because videos are a big thing to download/upload. Suppose there's an anime like One Piece or Fairy Tail or Naruto Shippuuden, they have like 500+ episodes. If every episode is downloaded simultaneously, it'll cause bottleneck problems. And even your system might crash.

  • I can do this, not a problem. I actually have a version on my end that can do this. However, it requires one more dependency... mkvmerge. I don't want to add one more external binary dependecy. I'm actually trying to get rid of ffmpeg as well, tbh. I'll implement this at a later stage.

  • Yes, that is planned. To make a config file or something so that you won't have to pass the credentials every time. I'll implement this is near future. I don't want to save or take cache or anything because its CloudFlare and they will definitely change something in this sooner or later and it might break the script. So, I'll be taking credentials from a config file.

Things I will push in new update :

  • Support for Funimation. Since Funimation changed their website, I was looking for ways to download from Funimation and found this on Youtube-dl. But, after inspecting their new website inside out, I figured out a faster and a better way. I have yet to implement this one.

@Xonshiz Xonshiz self-assigned this Mar 7, 2017
@Haejien
Copy link
Author

Haejien commented Mar 7, 2017

I was referring to setting something like a "transfers" (e.g. --transfers=10) flag. I know anyone couldn't download 400 episodes at once but having gigabit internet I could easily handle 5+ concurrent streams. As for dependencies, it is sort of a pain to use them on windows, however on linux, which what I feel most people would be using anyway, it's pretty easy to manage.

@Xonshiz
Copy link
Owner

Xonshiz commented Mar 7, 2017

I don't think mkvmerge and FFmpeg come pre-installed or maintained on Linux as well (will check later today on my machine). I see the transfer flag thing now. Nice idea. I'll implement it after I add support for Funimation :)

@Haejien
Copy link
Author

Haejien commented Mar 7, 2017

Well (referring to ubuntu), in the case of mkvmerge you do have to add a repository source, but ffmpeg was removed in in 14.xx but re added into the default repository starting in 15.04.

@Xonshiz
Copy link
Owner

Xonshiz commented Mar 7, 2017

Ah, I see. But, I'm trying to make this script run on every platform without any external binary. dependency. I'll see what I can do 👍

@MrDonGato
Copy link

any way to download only subtitles? i try to download only the subs and use other sources for video.

@Xonshiz
Copy link
Owner

Xonshiz commented Mar 13, 2017

Nothing for just subs yet.

@MrDonGato
Copy link

i'll subscribe to this to see when you put subs-only :D

@Xonshiz
Copy link
Owner

Xonshiz commented Mar 27, 2017

Whole show ripping support added. "Only Subs" part should come by next week, I guess.

Xonshiz added a commit that referenced this issue Apr 13, 2017
Fix for #6 and #3
Read the
[Changelog](https://github.com/Xonshiz/anime-dl/blob/master/Changelog.md)
for more information and check the
[README](https://github.com/Xonshiz/anime-dl#windows-binary) to know how
to use this.
@Xonshiz
Copy link
Owner

Xonshiz commented Apr 13, 2017

Added the "Only Subs" download part. Will be closing this.

@Xonshiz Xonshiz closed this as completed Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants