Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add leading zeros #18

Closed
vomov opened this issue Jun 6, 2017 · 15 comments
Closed

add leading zeros #18

vomov opened this issue Jun 6, 2017 · 15 comments
Assignees

Comments

@vomov
Copy link

vomov commented Jun 6, 2017

I use comicrack for reading the downloaded comics, and I have a batch script that packs the folders into cb7 files. Because Comicrack is stupid with the numbering, I need to add leading zeros to the filenames.

Would this be possible?

@Xonshiz Xonshiz self-assigned this Jun 6, 2017
@Xonshiz
Copy link
Owner

Xonshiz commented Jun 6, 2017

I can't promise anything. But, I will surely look into this.

Xonshiz added a commit that referenced this issue Jun 12, 2017
Re-wrote complete script. Check the "Changelog" for more information. Some sites have been removed for now, please check the updated "Supported Sites"
@Xonshiz
Copy link
Owner

Xonshiz commented Jun 12, 2017

This should be fixed now.

@Xonshiz Xonshiz closed this as completed Jun 12, 2017
@jaxxa
Copy link

jaxxa commented Jun 23, 2017

This still appears to be an issue for me. It is prepending 0 to all of the file names, when it should only prepend it to filenames smaller than the the maximum length. This is keeping it in the incorrect order as before.

For example now it is going:

01.jpg
010.jpg
011.jpg
012.jpg
...
019.jpg
02.jpg
020.jpg
...

I am using the latest windows binary release.

Here is the Gist, although this is not throwing an error so I dont think that it will be of any help.

https://gist.github.com/jaxxa/555bf9227087460760337ee2b27297ea

If you prefer i can log this as a separate issue.

@Xonshiz
Copy link
Owner

Xonshiz commented Jun 25, 2017

Open a separated issue please. And also, what did you mean by this line
when it should only prepend it to filenames smaller than the the maximum length.

It would be great if you could elaborate this naming sequence you want.

@vomov
Copy link
Author

vomov commented Jun 25, 2017

I suspect he means that it should only pad until it reaches the longest number. For example, if a comic has 30 pages, then it should pad 4 to 04, and leave anything with two digits alone (12 stays 12), while if a comic has 200 pages, 4 should become 004, and 12 should become 012.

@Xonshiz
Copy link
Owner

Xonshiz commented Jun 25, 2017

I hope he doesn't mean this. xD!
Too much work hahah

@jaxxa
Copy link

jaxxa commented Jun 25, 2017

Ok, I will log it as a new issue when I get Home.

@Xonshiz
Copy link
Owner

Xonshiz commented Jan 1, 2018

I had to remove this feature to fix a few things. I'm re-opening this and will try to bring this back in a few days.

@Xonshiz Xonshiz reopened this Jan 1, 2018
@DyeffersonAz
Copy link

Is this enabled right now?

@Xonshiz
Copy link
Owner

Xonshiz commented Jan 28, 2018

Nope.

@DyeffersonAz
Copy link

What is these THINGS???

@Xonshiz
Copy link
Owner

Xonshiz commented Feb 14, 2018

?

@DyeffersonAz
Copy link

image

@Xonshiz
Copy link
Owner

Xonshiz commented Feb 14, 2018

Check the code as on Jan 1, you should see the changes I made, the feature I added or a bug I fixed. Plus, the previous implementation was very bad, hence, had to remove it.

@Xonshiz Xonshiz changed the title [Feature-request] add leading zeros add leading zeros Apr 10, 2018
@DyeffersonAz
Copy link

It is working on readcomiconline.to ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants