launcher does not honour SSH password on OSX

[totaam]

Issue migrated from trac ticket # 1240

component: android | priority: major | resolution: fixed

2016-06-24 21:21:33: uberbrodt created the issue

---

The client says that connection is lost. However, binding tcp works.

Starting the client from the commandline allowed me to see output of the client. Looks like there's a python error, and then it asks for my password to the remote server. Providing the correct password connects and everything works from there. Details are in the bug report attached.

[totaam]

2016-06-24 21:22:14: uberbrodt uploaded file xpra_bug_report.zip (2152.3 KiB)

Bug report

[totaam]

2016-06-25 05:26:15: antoine changed status from new to assigned

[totaam]

2016-06-25 05:26:15: antoine commented

---

The stacktrace from the bug report tool is:

Traceback (most recent call last):
  File "/Applications/Xpra.app/Contents/Resources/lib/python/xpra/platform/darwin/gui.py", line 370, in ready
    self.setup_event_listener()
  File "/Applications/Xpra.app/Contents/Resources/lib/python/xpra/platform/darwin/gui.py", line 385, in setup
_event_listener
    class Delegate(NSObject):
error: Delegate is overriding existing Objective-C class

Could be caused by the sleep / wake (#1137 / r12271) or the tray deiconify hook. (#965 / r12162)
This should not be fatal.

@uberbrodt: you will not be prompted for a password when using the GUI, you should be typing in your password there.
I will check that this still works as expected.
From the bug report, the OS is "El Capitan" (Darwin-15.5.0-x86_64-i386-32bit) so maybe the SSH password script stopped working on this version of the OS.

[totaam]

2016-06-28 01:56:27: uberbrodt commented

---

When running from the GUI, I was typing the password into the provided input, but it was giving me a "connection closed" error (or something like that). I only tried the command line after that. I am on the latest El Capitan. Thanks for looking into this so quickly!

[totaam]

2016-07-12 17:52:23: antoine commented

---

Milestone renamed

[totaam]

2016-08-04 09:59:43: antoine changed status from assigned to new

[totaam]

2016-08-04 09:59:43: antoine changed owner from antoine to uberbrodt

[totaam]

2016-08-04 09:59:43: antoine changed title from Error connecting over SSH from Mac OSX to launcher does not honour SSH password on OSX

[totaam]

2016-08-04 09:59:43: antoine commented

---

The Delegate stacktrace is unrelated, I am moving it to #1277.

The SSH problem only occurs when using the launcher (I have edited the ticket summary to clarify).
We were shipping an SSH_ASKPASS script, but we never hooked it up, in any case the ssh process does not seem to honour it (tested on OSX and Linux), despite those claims:

• Tell SSH to use a graphical prompt for key passphrase
• Can I get SSH to use an askpass program even if it was run from a terminal?
• reading SSH password from stdin – the openssh 5.6p1 compatible way

So a much better solution is to use sshpass, which is available for Fedora, Debian, etc... but not centos.
r13201 does this, including the packaging updates for building it on OSX. (need updates up to r13207 to fix some epic bloopers I made along the way)

Tested on OSX and Fedora.
@uberbrodt: please test the latest [http://xpra.org/beta] and close if this works for you.

[totaam]

2016-08-10 05:23:16: antoine changed owner from uberbrodt to smo

[totaam]

2016-08-10 05:23:16: antoine commented

---

@smo: over to you.

[totaam]

2016-08-10 11:34:53: davide commented

---

Help appreciated. I installed newer beta version and it seemed to get farther (didn't immediately disconnect) but the GUI just disappeared and
nothing more happened.
[i.e., I was waiting for a window to open and it never did]

[totaam]

2016-08-10 11:37:33: antoine commented

---

@davide: see #1281#comment:1 and try from the command line so you can see what is happening in more detail. You have yet to include what version you are using or what command lines you used to start the server, show the server log file, etc. All making it really hard to follow what you are doing.

[totaam]

2016-08-10 11:44:51: davide commented

---

As you suggested I am using the latest version of the gui and have showed you in the screenshot the entirety of what I am trying. I am on El Capitan.

I have no command line version in MAC so cannot try what you said

[totaam]

2016-08-10 11:48:13: antoine commented

---

have showed you in the screenshot the entirety of what I am trying
[[BR]]
Blatantly not. See #1281#comment:1, server version still missing, server command still missing, have you tried connecting from an ubuntu client? also missing. Server log, missing.

[[BR]]

I have no command line version in MAC so cannot try what you said
[[BR]]
Again. See comment.

[totaam]

2016-08-13 20:04:53: uberbrodt changed status from new to closed

[totaam]

2016-08-13 20:04:53: uberbrodt set resolution to fixed

[totaam]

2016-08-13 20:04:53: uberbrodt commented

---

Downloaded the beta today and tested. Works like a champ. Thanks!