Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-opengl backend rendering issues #1874

Closed
totaam opened this issue Jun 11, 2018 · 6 comments
Closed

non-opengl backend rendering issues #1874

totaam opened this issue Jun 11, 2018 · 6 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Jun 11, 2018

Issue migrated from trac ticket # 1874

component: client | priority: blocker | resolution: fixed

2018-06-11 17:21:55: antoine created the issue


Found by testing for #1658 with:

  • wayland as vfb
  • a patch to return True from check_randr_sizes
  • opengl=no

With python2, the rendering is broken, with python3 the client crashes!

@totaam
Copy link
Collaborator Author

totaam commented Jun 14, 2018

2018-06-14 10:49:12: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Jun 14, 2018

2018-06-14 10:49:12: antoine commented


r19645 adds better debug logging.
The problem seems to come from relative vs absolute coordinates: some methods call queue_draw with relative coordinates, others expect it to honour absolute coordinates and repaint the whole window, including the padding area..

@totaam
Copy link
Collaborator Author

totaam commented Jun 14, 2018

2018-06-14 14:40:38: antoine commented


Large fix in r19647, also fixes the crashes with python3. (looks like cairo / python3 doesn't do enough validation and just crashes... python2 just renders junk?)
queue_draw is part of the GTK API, we should always use absolute window coordinates there.

Other related changesets:

@totaam
Copy link
Collaborator Author

totaam commented Jun 14, 2018

2018-06-14 14:40:57: antoine changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Jun 14, 2018

2018-06-14 14:40:57: antoine set resolution to fixed

@totaam totaam closed this as completed Jun 14, 2018
@totaam
Copy link
Collaborator Author

totaam commented Aug 5, 2019

2019-08-05 17:24:34: @totaam commented


r19647 caused a regression: #1339#comment:35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant