-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome-terminal sides not rendered fully #2618
Comments
2020-03-03 21:26:05: stdedos uploaded file
|
2020-03-03 21:28:36: stdedos commented
|
2020-03-03 21:28:49: stdedos uploaded file
|
2020-03-04 05:12:28: antoine commented
|
2020-03-05 08:28:08: stdedos uploaded file
|
2020-03-05 08:31:03: stdedos commented
|
2020-03-19 14:17:33: stdedos commented
|
I can reproduce by changing the terminal font size. (see also #2526 - closed as duplicate) This is caused by GTK3 not honouring window size hints properly: terminals set size increments matching the font size. We probably should clear the window at least once following a resize. (but too late for 4.0) |
The
But that's not ideal. |
This is likely to be related to #2516. |
Clarifying the two offsets. The client window's Typically: when we reposition an OR window to ensure it is visible on screen, or when we use padding around a fixed sized window when it is maximized or fullscreen. It is set from:
It is taken into account in:
The window backing's It is set from:
It is used in:
Based on this, I believe that r27519 is correct. @stdedos: does that fix things for you? (updated win32 beta builds with this fix are available) Sorry it's taken so long to identify the bug! |
2020-09-21 16:15:04: stdedos commented
Client-only fix? No need to backport for Windows (for me), as the portable builds + argparse configuration fits very nicely into my workflow.
I have been seeing that specific code piece for a while now - no wonder it took so much time to figure it out. I can try it tomorrow by playing with the font size - however, otherwise, I don't remember having seen it recently. |
The window still behaves weirdly when changing the font size. While maximized:
I could accept though, that both of these issues are not "fixed-size windows receive incomplete repaints" |
Issue migrated from trac ticket # 2618
component: client | priority: blocker
2020-03-03 21:25:35: stdedos created the issue
The text was updated successfully, but these errors were encountered: