IE11 Support

[totaam]

Issue migrated from trac ticket # 1973

component: html5 | priority: minor | resolution: fixed

2018-10-01 19:12:02: mjharkin created the issue

---

@antoine Looks like I'm a little late on this as I think you've covered most of this in r20580 but maybe missing:

Fullscreen request:Added IE11 fullscreen request

startsWith and includes Polyfills
My approach was to add a seperate polyfill script so it's easier to remove when IE finally dies. For reference added IE11 compatability

[totaam]

2018-10-02 06:45:06: antoine changed owner from antoine to mjharkin

[totaam]

2018-10-02 06:45:06: antoine edited the issue description

[totaam]

2018-10-02 06:45:06: antoine commented

---

Merged in r20583 + r20584, thanks.

Can you please specify what copyright applies to those polyfills? (should be the same as ECMA6 I guess - looks like a BSD variant?)

[totaam]

2018-10-02 13:22:33: mjharkin commented

---

Sorry, started here https://github.com/paulmillr/es6-shim (MIT) but it was overkill for a few polyfills so ended up just grabbing them from elsewhere, I've already give myself a slap on the wrists!

Just tested r20584 but I think:

window.console = window.console || {
	  log: function () {}
};
	

needs to be in index.html otherwise Developer tools needs to be open.

[totaam]

2018-10-02 13:51:12: antoine commented

---

needs to be in index.html otherwise Developer tools needs to be open.
No idea where that needs to go, I've tried a few obvious places and none helped.
(and since having the developer console open "fixes" things, catch 22)

[totaam]

2018-10-02 14:09:10: mjharkin commented

---

Sorry my mistake I should have tidied up before submitting the change:

What's missing is actually (1st diff from mjharkin/Xpra@5904fe3 )
This could equally be added to es6-shim.js instead of index.html, depends on your preference.

var console = console || { log: function(){} };

The following should be removed from es6-shim.js

window.console = window.console || {
	  log: function () {}
};

[totaam]

2018-10-02 15:29:46: antoine commented

---

Thanks, applied in r20592.

Can we close this ticket?

[totaam]

2018-10-02 15:57:19: mjharkin commented

---

r20592 changes in index.html and connect.html can be removed.
Otherwise this is good to close.

Thanks.

[totaam]

2018-10-02 16:13:40: antoine changed status from new to closed

[totaam]

2018-10-02 16:13:40: antoine set resolution to fixed

[totaam]

2018-10-02 16:13:40: antoine commented

---

Good catch, done in r20593.

[totaam]

2019-03-04 12:11:42: mjharkin changed status from closed to reopened

[totaam]

2019-03-04 12:11:42: mjharkin removed resolution (was fixed)

[totaam]

2019-03-04 12:11:42: mjharkin commented

---

Try catch blocks without an argument were added recently.
IE11 doesn't like this, fix is to add the argument:

mjharkin/Xpra@a3258e7

[totaam]

2019-03-04 12:21:59: antoine changed status from reopened to closed

[totaam]

2019-03-04 12:21:59: antoine set resolution to fixed

[totaam]

2019-03-04 12:21:59: antoine commented

---

Thanks!
Applied in r21961.