Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use video encoders more aggressively - but not nvenc #2044

Closed
totaam opened this issue Nov 18, 2018 · 8 comments
Closed

use video encoders more aggressively - but not nvenc #2044

totaam opened this issue Nov 18, 2018 · 8 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 18, 2018

Issue migrated from trac ticket # 2044

component: encodings | priority: major | resolution: fixed

2018-11-18 06:19:06: antoine created the issue


See #2029#comment:13 : using video encoders saves lots of bandwidth and isn't that much more expensive than "jpeg" or "webp".
The only exception is NVENC (see #2022): those encoder contexts are expensive, so we don't want to use them unless we are certain that this is going to last.

@totaam
Copy link
Collaborator Author

totaam commented Nov 19, 2018

2018-11-19 05:05:34: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Nov 19, 2018

2018-11-19 05:05:34: antoine commented


See also #2046

@totaam
Copy link
Collaborator Author

totaam commented Nov 19, 2018

2018-11-19 08:32:37: antoine commented


#2043 would help so we could rely on the damage statistics.

@totaam
Copy link
Collaborator Author

totaam commented Nov 19, 2018

2018-11-19 14:10:02: antoine uploaded file gradual-setup-cost.patch (4.1 KiB)

gradual decrease in setup cost

@totaam
Copy link
Collaborator Author

totaam commented Nov 19, 2018

2018-11-19 14:37:05: antoine commented


With the patch above, nvenc doesn't get used for the first 20 or 30 frames.
But it doesn't take into account the number of frames per second, which is more important than the raw number of frames. But this would require #2043

@totaam
Copy link
Collaborator Author

totaam commented Nov 20, 2018

2018-11-20 17:18:42: antoine changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Nov 20, 2018

2018-11-20 17:18:42: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Nov 20, 2018

2018-11-20 17:18:42: antoine commented


r21057 does this but using the current fps value: encoders with a high setup cost (ie: nvenc) won't be chosen until the framerate is high enough (defaults to 5fps)

See also #2048 which would alleviate nvenc's slow start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant