Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a novideo content-type #2100

Closed
totaam opened this issue Jan 7, 2019 · 10 comments
Closed

add a novideo content-type #2100

totaam opened this issue Jan 7, 2019 · 10 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Jan 7, 2019

Issue migrated from trac ticket # 2100

component: encodings | priority: major | resolution: fixed

2019-01-07 22:52:41: nathan_lstc created the issue


Some of my users really dislike video frames in xterm. With this patch, users can (1) set a novideo content type and (2) set a guesser rule from an environment variable (from a systemd entry I have):

Environment=XPRA_CONTENT_TYPE_DEFS=class-instance:xterm=novideo
@totaam
Copy link
Collaborator Author

totaam commented Jan 7, 2019

2019-01-07 22:53:03: nathan_lstc uploaded file novideo-content-type.patch (4.8 KiB)

@totaam
Copy link
Collaborator Author

totaam commented Jan 8, 2019

2019-01-08 04:00:23: antoine changed owner from antoine to nathan_lstc

@totaam
Copy link
Collaborator Author

totaam commented Jan 8, 2019

2019-01-08 04:00:23: antoine commented


I like the idea.

We could just add a new flag like TEXT_NOVIDEO. This would apply to all applications that are meant to be text.

This does not use lossless:

            return nonvideo(info="lossless content-type")

It will use a non-video encoding, usually at a high quality setting, but not lossless unless you change the quality value with this call.
And if you do, then you might as well call the new content-type "lossless"?

@totaam
Copy link
Collaborator Author

totaam commented Jan 8, 2019

2019-01-08 18:35:30: nathan_lstc commented


I had originally gone with lossless and then changed my mind after trying nonvideo and finding myself happy with that. I forgot to change the text is all.

I am okay with either choice. I defer to you.

@totaam
Copy link
Collaborator Author

totaam commented Jan 8, 2019

2019-01-08 18:36:29: nathan_lstc changed type from defect to enhancement

@totaam
Copy link
Collaborator Author

totaam commented Jan 8, 2019

2019-01-08 18:36:29: nathan_lstc changed component from android to encodings

@totaam
Copy link
Collaborator Author

totaam commented Jan 9, 2019

2019-01-09 15:42:07: antoine commented


The part adding an env var for specifying content type definitions was merged in r21302 (see #1950#comment:8).
r21303 disables video encoders for windows with the "text" content-type hint.

@nathan_lstc: does this work OK for you? if so, please close.

@totaam
Copy link
Collaborator Author

totaam commented Jan 9, 2019

2019-01-09 17:53:35: nathan_lstc changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Jan 9, 2019

2019-01-09 17:53:35: nathan_lstc set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Jan 9, 2019

2019-01-09 17:53:35: nathan_lstc commented


This is great! Thank you.

@totaam totaam closed this as completed Jan 9, 2019
@totaam totaam added the v2.4.x label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant