Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.1: text flickery with x264 and min-quality<70 #245

Closed
totaam opened this issue Feb 4, 2013 · 7 comments
Closed

0.8.1: text flickery with x264 and min-quality<70 #245

totaam opened this issue Feb 4, 2013 · 7 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 4, 2013

Issue migrated from trac ticket # 245

component: core | priority: major | resolution: wontfix

2013-02-04 03:02:45: onlyjob created the issue


With 0.8.0 and 0.8.1 I experience text "flickery" (visual distortion) in kate with "x264" encoding and min-quality < 70.

With several paragraphs of text in kate all text is flashing in the rhythm of cursor flashing. Setting min-quality to 70 is enough to fix the problem.

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2013

2013-02-04 04:09:11: antoine changed status from new to accepted

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2013

2013-02-04 04:09:11: antoine changed owner from ** to antoine

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2013

2013-02-04 04:09:11: antoine commented


70 is the minimum quality level for YUV422, below that you would be using YUV420 colour subsampling.

What is strange is that you get a full window refresh with just a cursor change. I guess that kate is updating the whole line or something, so we end up with a full window refresh rather than a small lossless (png/rgb24) region. Will test.

@totaam
Copy link
Collaborator Author

totaam commented Feb 6, 2013

2013-02-06 17:12:45: antoine commented


Just tested and I managed to reproduce the flickering issue in Kate. That's because the Kate application re-paints the whole line (or more?) every time the cursor blinks - so xpra does a full window refresh using x264. Then
shortly after the auto-refresh kicks in and does a lossless refresh at
high quality.
The flickering is due to the difference in quality between regular
frames and almost-lossless frames.

I'm trying to find out why the quality isn't higher on "auto" when Kate
is idle (just the cursor blinking), "xpra info" reports a quality of about ~80% when it looks like it should go much higher (and therefore avoid all flickering by virtue of already being lossless).

PS: The problem manifests even more wildly if kate has spellchecking enabled and some words are underlined.

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2013

2013-03-20 13:51:46: antoine changed status from accepted to closed

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2013

2013-03-20 13:51:46: antoine changed resolution from ** to wontfix

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2013

2013-03-20 13:51:46: antoine commented


I don't think there is much we can do about this at all, when using YUV422 or YUV420, the colour subsampling will do this - the only way to avoid it is to not use it: setting a quality high enough so that YUV444 is used (by default the threshold is at 90%).


The quality and min-quality options can be set:

  • via /etc/xpra/xpra.conf
  • via ~/.xpra/xpra.conf
  • via the command line
  • via the applet

@totaam totaam closed this as completed Mar 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant