Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim bundled icons #2563

Closed
totaam opened this issue Jan 25, 2020 · 4 comments
Closed

trim bundled icons #2563

totaam opened this issue Jan 25, 2020 · 4 comments
Labels
v3.0.x

Comments

@totaam
Copy link
Collaborator

totaam commented Jan 25, 2020

Issue migrated from trac ticket # 2563

component: platforms | priority: major | resolution: fixed

2020-01-25 09:31:58: antoine created the issue

We reduced the size of the win32 builds in #2550 but thanks to r25081 (for CSD and windows with a header bar), we've gained more than we had lost!

Find a way to trim the icons we bundle, and more importantly the metadata that goes with it.
@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2020

2020-02-04 09:39:02: @totaam changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2020

2020-02-04 09:39:02: @totaam set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2020

2020-02-04 09:39:02: @totaam commented

Done in r25141.

We've shaved off over 10MB of icon data we don't need and more importantly countless files which slowed down the installer.

@totaam totaam closed this as completed Feb 4, 2020
@totaam
Copy link
Collaborator Author

totaam commented Feb 6, 2020

2020-02-06 09:01:04: antoine commented

(this also fixed the missing theme icon: #2531)

@totaam totaam added the v3.0.x label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3.0.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam