Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpra upgrade :0 looks like a bad idea #2653

Closed
totaam opened this issue Mar 17, 2020 · 9 comments
Closed

xpra upgrade :0 looks like a bad idea #2653

totaam opened this issue Mar 17, 2020 · 9 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 17, 2020

Issue migrated from trac ticket # 2653

component: server | priority: minor | resolution: worksforme

2020-03-17 13:09:29: stdedos created the issue


I updated /etc/xpra/conf.d/80_lock.conf configuration file, and I was thinking how could I quickly update the server without stop/shadow.

Without much thinking I did xpra upgrade :0.

Now theming is different, fonts are different and applications have duplicated "File" menus (one in the normal Unity toolbar, one just when their drawing area starts).

Maybe I shouldn't be able to do that? Or you do it internally like a stop/shadow instead?

@totaam
Copy link
Collaborator Author

totaam commented Mar 17, 2020

2020-03-17 16:08:31: antoine changed owner from antoine to stdedos

@totaam
Copy link
Collaborator Author

totaam commented Mar 17, 2020

2020-03-17 16:08:31: antoine commented


Maybe I shouldn't be able to do that?
Correct, that's a bug, fixed in r25673. (backport in 25674)

For upgrading shadow servers, you are meant to stop it and start a new one, shadow servers aren't meant to linger around, they are usually started with --exit-with-client=yes.

Ideally, we would have an upgrade-shadow subcommand (same as upgrade-desktop), or even better: a generic upgrade command which would figure out what it is upgrading automatically. (but it's not as easy as it sounds)

@totaam
Copy link
Collaborator Author

totaam commented Mar 17, 2020

2020-03-17 16:53:21: antoine commented


This caused a regression, details in r25677.

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2020

2020-03-20 08:01:32: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2020

2020-03-20 08:01:32: antoine set resolution to worksforme

@totaam totaam closed this as completed Mar 20, 2020
@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2020

2020-03-20 09:55:29: stdedos commented


There are no new xpra builds to test against.

I understand you are going in release and you are cleaning up the tracker, but at least for some tickets there could be some grace period

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2020

2020-03-20 10:35:09: antoine commented


There are no new xpra builds to test against.

There are Xenial and win32 builds fresh from today.

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2020

2020-03-20 11:04:30: stdedos commented


Replying to [comment:5 Antoine Martin]:

There are no new xpra builds to test against.

There are Xenial and win32 builds fresh from today.

I trust you, and I've seen the changeset, but apt-get does not want to pick them up for some reason (apt-cache madison also agrees)

@totaam
Copy link
Collaborator Author

totaam commented Mar 20, 2020

2020-03-20 13:33:28: stdedos commented


Somehow you broke the xpra repo...
Edit: moved to #2663.

@totaam totaam added the v3.0.x label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant