Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running xpra in a pod/container #2989

Closed
totaam opened this issue Dec 27, 2020 · 6 comments
Closed

Running xpra in a pod/container #2989

totaam opened this issue Dec 27, 2020 · 6 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 27, 2020

Issue migrated from trac ticket # 2989

component: android | priority: major

2020-12-27 20:07:58: louis-mulder created the issue


referencing to r28061
I am not a experienced Python programmer so I attach my pamexec_auth.py module in Python version 2. This module works with the help of some bash scripts to startup a pod with a xpra-session. The Xpra proxy.... runs as an ingress-server in a K8 cluster. I have seen the new interface however after creating the pod it must update the capability display so the proxy knows where it must connect.
How difficult is it to convert this module to Python3 and using the new interface ?

Many thanks on the forehand.....
Louis

@totaam
Copy link
Collaborator Author

totaam commented Dec 27, 2020

2020-12-27 20:08:49: louis-mulder uploaded file pamexec_auth.py (8.4 KiB)

Python version of pamexec_auth.py

@totaam
Copy link
Collaborator Author

totaam commented Dec 27, 2020

2020-12-27 20:09:46: louis-mulder uploaded file start_pod.sh (2.8 KiB)

Bash script to startup a pod or get the ip-info

@totaam
Copy link
Collaborator Author

totaam commented Dec 27, 2020

2020-12-27 20:10:34: louis-mulder uploaded file startup_proxy.sh (11.1 KiB)

bash startup script xpra proxyand freeipa client

@totaam
Copy link
Collaborator Author

totaam commented Dec 27, 2020

2020-12-27 20:14:36: louis-mulder uploaded file xpra-proxy-443.sh (30.2 KiB)

deploying a Xpra ingress-server, shared storage is based on NFS

@totaam
Copy link
Collaborator Author

totaam commented Jan 13, 2021

So this is a follow up to #2933, right? Or a duplicate?
The ticket title is exactly the same.

I seem to remember saying this before but I can't locate the ticket comment: you should split your pamexec module: there is no need to duplicate so much code.
(and even if there was, you should import most of it from the other modules, not duplicate it)
Just configure your socket with two authentication modules (see Authentication), the first one is pam and the second one can do what you want.

See also #2933#comment:2 wrt capabilities. Don't use a global.

The command should be configurable.

Don't do this:

argv = c.strget("argv")

Just do: argv = c.strtupleget("argv") then you don't have to parse strings.

display = my_argv.split(u"/")[-1]

If you want to know the display specified by the user, there is a much easier way IIRC.

@totaam totaam added this to the 4.2 milestone Jan 24, 2021
@totaam
Copy link
Collaborator Author

totaam commented Jul 17, 2021

Not heard back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant