Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling direction changed #3129

Closed
stdedos opened this issue May 19, 2021 · 5 comments
Closed

Scrolling direction changed #3129

stdedos opened this issue May 19, 2021 · 5 comments

Comments

@stdedos
Copy link
Collaborator

stdedos commented May 19, 2021

From r29074 to r29129 (5addf28), the scrolling direction has changed.
Now I am scrolling downwards so that the view goes downwards i.e. to go to previous things.

I don't want to downgrade, because I want to verify #3023 (silencing the output does not hurt either)

@totaam
Copy link
Collaborator

totaam commented May 19, 2021

Very likely to have been caused by #3127.

@totaam
Copy link
Collaborator

totaam commented May 19, 2021

The commit above restores things (and will make smooth scrolling users unhappy?)
Otherwise, you can always use --mousewheel=invert-y.

@stdedos
Copy link
Collaborator Author

stdedos commented May 19, 2021

The commit above restores things (and will make smooth scrolling users unhappy?)
Otherwise, you can always use --mousewheel=invert-y.

I don't want to necessarily make smooth scrolling users unhappy; I am fine plugging that --mousewheel=invert-y somewhere (SO MANY configuration options with xpra 🤯)

Can't only the smooth scrolling be inverted, leaving "normal" scrolling alone? 😕
(idk what's "smooth scrolling" really)

@totaam
Copy link
Collaborator

totaam commented May 19, 2021

I don't want to necessarily make smooth scrolling users unhappy

The default should be unchanged. We can't break everyone's mousewheel just do add support for "smooth scrolling".

Can't only the smooth scrolling be inverted, leaving "normal" scrolling alone?

As per #3127 (comment) : I can't see an easy way to differentiate between real smooth scroll events and the ones synthesized from regular scroll wheels

I was hoping that the event's device Gdk.Device.get_source method would be it, but it returns Gdk.InputSource.MOUSE for my touchpad events instead of Gdk.InputSource.TOUCHPAD

@GbGp
Copy link

GbGp commented May 19, 2021

I noticed that the scrolling direction was inverted respect my system default, but I assumed it was a misconfiguration on my part.
I think this commit restores normal behavior even for the smooth scrolling case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants