--key-shortcut masks all other shortcuts in "XPRA Keyboard Shortcuts" window

[stdedos]

I've set the refresh_all_windows shortcut, and now that's the only one that's visible

[totaam]

We can't just always append to the existing defaults otherwise there would not be a way of removing the default values, only append to them.

I guess we could add a magic value of clear for that.
Or perhaps --keyboard-shortcut=defaults --keyboard-shortcut=Shift+F9:refresh_all_windows?

[stdedos]

I guess we could add a magic value of clear for that.
Or perhaps --keyboard-shortcut=defaults --keyboard-shortcut=Shift+F9:refresh_all_windows?

I prefer the clear way. Or, for more fine-tuned shortcut handling, --keyboard-shortcut=Shift+F9:- to clear a shortcut.

[totaam]

Done.

Examples:

xpra attach --key-shortcut=Shift+F9=show_session_info

(all the default shortcuts are still present, this one is added or replaces any existing one from the defaults)

xpra attach --key-shortcut=#+F1:pass

Allows #+F1 (which is Control+Shift+F1 with Gnome Shell) to reach the application.

xpra attach --key-shortcut=#+F1:-

Same thing but the implementation is a little bit different, which could be useful down the line:

• pass is a virtual action which triggers the usual shortcut handling code and falls through to the client application
• - just removes the shortcut and the shortcut handling code won't be triggered at all

Please close if this works for you.

[stdedos]

LGTM!

"Xpra-Python3-x86_64_4.3-r29346\xpra_cmd" attach ssh://user@ip/2 --ssh="plink -ssh -agent" --title="@title@ on @@/@server-display@" --modal-windows=no --headerbar=off --use-display=yes --input-method=xim --key-shortcut=#+F10:- --key-shortcut=#+R:refresh_all_windows --encodings=jprg,rgb,png --video-encoders=vpx --csc-modules=libyuv --opengl=no