Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to accept ssl mismatched host permanently #3305

Closed
totaam opened this issue Oct 14, 2021 · 1 comment
Closed

option to accept ssl mismatched host permanently #3305

totaam opened this issue Oct 14, 2021 · 1 comment
Labels
client enhancement New feature or request

Comments

@totaam
Copy link
Collaborator

totaam commented Oct 14, 2021

See #3299. Useful for self-signed certs.

The MS Windows and MacOS builds use a custom dialog to prompt the user so this could easily be enhanced with a checkbox to make the choice permanent and save the option in the ssl directory for this host + port.
On Linux, this won't work because pinentry is too limited: #3299 (comment)
@totaam totaam added enhancement New feature or request client labels Oct 14, 2021
@totaam totaam mentioned this issue Apr 3, 2022
Closed
totaam added a commit that referenced this issue Jul 8, 2022
@totaam
#3305 save generic ssl options to host+port file
2417060
totaam added a commit that referenced this issue Jul 8, 2022
@totaam
#3305 process ssl options parsing earlier
306edee 
so we can still have access to the command line and decide which options should be overriden by the options object and which options should be loaded from the per host+port configuration file
@totaam
Copy link
Collaborator Author

totaam commented Jul 8, 2022 •
edited

Done with separate prompts to keep things simple. Needs testing on MacOS + MS Windows.

The second commit is much bigger than I thought it was going to be because the parsing needed to be moved.
The parse_display_name function needed the command line to be added to its signature and it is used in a lot of places..

@totaam totaam closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam