New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow max-quality setting #3420
Comments
Did you figure out why you're getting this @TijZwa Was your video also encoded with 70% quality? Can you provide a brief There are a number of things that this may interfere with, which is why I haven't implemented it yet:
|
@totaam Yes, I've only rgb + png + webp enabled, as webp offers me the best balance between speed and quality. I would like xpra to choose between two fixed numbers, like min-quality=50 & max-quality=80. |
Beyond a certain size,
Perhaps we can avoid this costly frame without limiting the quality to an arbitrary value. Just as important, we want to know if the pixel data is compressed with the alpha channel or not. (same issue as #3410) |
The commit above makes it easier to play with
Playing with these new knobs I am quite concerned that they are going to be misused and lead people to believe that this is the official or correct way of sacrificing quality for bandwidth or framerate when it is not. @TijZwa please see the questions in the comment above. |
@totaam Nice! I will test this soon. |
@TijZwa I meant getting the |
Is your feature request related to a problem? Please describe.
When using Xpra as VDI solution over a very fast and reliable link, sometimes we get frames/pictures that are encoded with a quality that is too high for the purpose. Ie: When using webp a quality of 70% is very decent quality.
But a frame with 95%+ encoding makes a running video stutter because it's too big/takes longer to encode/takes longer to decode.
Describe the solution you'd like
It would be nice to be able to set a max-quality param.
Describe alternatives you've considered
Tuning speed and refresh is also a solution, but max-quality would be a bit more convenient.
The text was updated successfully, but these errors were encountered: