Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cython brotli compressor #3572

Closed
totaam opened this issue Jul 10, 2022 · 3 comments
Closed

cython brotli compressor #3572

totaam opened this issue Jul 10, 2022 · 3 comments
Labels
enhancement New feature or request network

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 10, 2022

Extend the Cython code in #3258 to support compression so that we can completely drop the dependency on python-brotli.
(perhaps just keep it as fallback in the loader)
@totaam totaam added enhancement New feature or request network labels Jul 10, 2022
totaam added a commit that referenced this issue Jul 10, 2022
@totaam
#3572 brotli cython compressor
c11fd3f
totaam added a commit to Xpra-org/gtk-osx-build that referenced this issue Jul 10, 2022
@totaam
python3-brotli is no longer needed
7dd0eda 
We now use Cython bindings: Xpra-org/xpra#3572
totaam added a commit that referenced this issue Jul 10, 2022
@totaam
#3572 remove dependencies on python3-brotli
93a5764
@totaam totaam closed this as completed Jul 10, 2022
totaam added a commit that referenced this issue Jul 15, 2022
@totaam
#3572 packaging updates
75a282a
@totaam
Copy link
Collaborator Author

totaam commented Jul 18, 2022

This typo f3d68a8 reveals that some builds are not using the Cython version?
(see #3386 (comment))

@totaam totaam mentioned this issue Jul 18, 2022
Closed
@stdedos
Copy link
Collaborator

stdedos commented Jul 18, 2022

I did get some apt-get telling me that python-brotli is not needed anymore recently (like a 10d ago?), "and I guessed it was you" 😛

I think I have done an apt-get autoremove --purge, but "maybe it's still there"?

totaam added a commit that referenced this issue Jul 29, 2022
@totaam
#3572 brotli option toggles the module
24dd03e
totaam added a commit that referenced this issue Aug 27, 2022
@totaam
#3572 we only need the lib
6be157c
@totaam
Copy link
Collaborator Author

totaam commented Jul 18, 2023

This bug was causing brotli failures: #3829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request network
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stdedos @totaam