Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose scaling quality #3598

Closed
totaam opened this issue Aug 1, 2022 · 1 comment
Closed

expose scaling quality #3598

totaam opened this issue Aug 1, 2022 · 1 comment
Labels
encoding enhancement New feature or request wontfix This will not be worked on

Comments

@totaam
Copy link
Collaborator

totaam commented Aug 1, 2022

As per Xpra-org/xpra-html5#198 (comment)
It would be useful to know the quality used for scaling and compression so that we use a quality at least as high when upscaling client-side.
@totaam totaam added enhancement New feature or request encoding labels Aug 1, 2022
@totaam totaam mentioned this issue Aug 1, 2022
Merged
totaam added a commit that referenced this issue Aug 23, 2022
@totaam
#3598 expose 'low' 'scaling-quality' for nvenc and nvjpeg
de9df44 
as those two encoders use our own dumb CUDA scaling kernels which produce low quality output
@totaam totaam added the wontfix This will not be worked on label Aug 23, 2022
@totaam
Copy link
Collaborator Author

totaam commented Aug 23, 2022

I started working on this and decided that it wasn't worth the added complexity.
Both the colourspace conversion step and the actual video encoder can affect quality and may each apply some downscaling. Also, the encoder quality is just as relevant.

The only user at present is the html5 client and it can now use low scaling quality when the bitmap went through one of our low quality CUDA colourspace conversion kernels.
For everything else, it will use medium: Xpra-org/xpra-html5@65b5624

That's good enough.

@totaam totaam closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encoding enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam