Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

randr_bindings: value overflow on 32-bit systems #3685

Closed
ptrcnull opened this issue Nov 11, 2022 · 2 comments
Closed

randr_bindings: value overflow on 32-bit systems #3685

ptrcnull opened this issue Nov 11, 2022 · 2 comments
Labels
bug Something isn't working linux X11

Comments

@ptrcnull
Copy link

Describe the bug
Xpra randr bindings don't build under 32-bit systems with default C flags:

xpra/x11/bindings/randr_bindings.c:10004:27: error: unsigned conversion from 'long long int' to 'long unsigned int' changes value from '30000000000' to '4230196224' [-Werror=overflow]
10004 |   __pyx_v_maxPixelClock = 0x6FC23AC00;
      |                           ^~~~~~~~~~~

To Reproduce
Steps to reproduce the behavior:

  1. python3 setup.py build

System Information (please complete the following information):

  • Server OS: Alpine Linux edge x86
  • Xpra Server Version: 4.4.2

Additional context
https://gitlab.alpinelinux.org/ptrcnull/aports/-/jobs/901800#L1489
@ptrcnull ptrcnull added the bug Something isn't working label Nov 11, 2022
totaam added a commit that referenced this issue Nov 12, 2022
@totaam
#3685 clamp clock values to 'unsigned long'
3f5eb97
@totaam
Copy link
Collaborator

totaam commented Nov 12, 2022

@ptrcnull Does the commit above fix things for you?

FYI: 32-bit builds are barely supported.

@nekopsykose
Copy link

it works now, thanks

totaam added a commit that referenced this issue Nov 13, 2022
@totaam
#3685 clamp clock values to 'unsigned long'
b31f50f
algitbot pushed a commit to alpinelinux/aports that referenced this issue Nov 13, 2022
@ptrcnull @nekopsykose
community/xpra: backport patch for value overflow on 32-bit platforms
e6488cf 
Xpra-org/xpra#3685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working linux X11
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@totaam @ptrcnull @nekopsykose