Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.x branch compatibility issue with html5 v5.x #3772

Closed
totaam opened this issue Feb 25, 2023 · 2 comments
Closed

3.1.x branch compatibility issue with html5 v5.x #3772

totaam opened this issue Feb 25, 2023 · 2 comments
Labels
bug Something isn't working network

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 25, 2023

When running against a v3.1.x server, there is only rencode and bencode packet encoders available and so the server chooses bencode.

info-response packets trigger a network parsing error because the network parsing code in the html5 client has been re-worked to prefer rencodeplus (#3229) and not use rencode (too many unfixable problems).

This is not easily fixable - especially in an EOL branch. Potential solutions:

  • don't send info-response packets with bencode (+ html5 client?)
  • add rencodeplus to the v3.1.x branch
@totaam totaam added bug Something isn't working network labels Feb 25, 2023
totaam added a commit that referenced this issue Feb 25, 2023
@totaam
Copy link
Collaborator Author

totaam commented Feb 25, 2023

Sample packet causing parsing error in html5 client : html5-bdecode-packet.txt

The commit above adds rencodeplus - this may still be reverted if this causes problems.
For a start, this also required a fix to the v5.x branch of the html5 client: Xpra-org/xpra-html5@67259c4

totaam added a commit that referenced this issue Feb 25, 2023
@totaam
Copy link
Collaborator Author

totaam commented Mar 3, 2023

Make it easy to drop rencodeplus in case of problems:

  • run with --packet-encoders=bencode,rencode
  • nuke the rencodeplus directory in the python lib folder
    Both work.

@totaam totaam closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working network
Projects
None yet
Development

No branches or pull requests

1 participant