Image.ANTIALIASING is deprecated and removed from the Pillow library.

[btasdelen]

As of Pillow 10.0, Image.ANTIALIASING (and its alias Image.LANCZOS) is deprecated and removed. This causes the following error on Xpra:

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/xpra/client/client_base.py", line 1152, in call_handler
    handler(packet)
  File "/usr/lib/python3.11/site-packages/xpra/client/mixins/window_manager.py", line 1074, in _process_window_icon
    img = self._window_icon_image(wid, w, h, coding, data)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/xpra/client/mixins/window_manager.py", line 720, in _window_icon_image
    xpra_resized = self.overlay_image.resize((overlay_width, overlay_height), Image.ANTIALIAS)
                                                                              ^^^^^^^^^^^^^^^
AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

I found two places where Image.ANTIALIAS is called, in xpra/client/mixins/window_manager.py line 710 and 720. Replacing Image.ANTIALIAS with Image.Resampling.LANCZOS seems to solve the issue. I checked the documentation, and this property is introduced in Pillow 1.1.3, so unless Xpra aims to be compatible with older versions of the library, it seems logical to replace them.

Edit: On the latest commit on master branch, line numbers are 763 and 773.

[totaam]

Thanks, the commit above should fix that (untested).
This constant was used in 7 separate files.

[btasdelen]

@totaam Image.LANCZOS is also removed. It should be Image.Resampling.LANCZOS.

[totaam]

@bilal-tasdelen is the commit above any better?

[btasdelen]

@totaam Yes, it should work. Thank you!