Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow does not work with 0.14.20 #822

Closed
totaam opened this issue Mar 12, 2015 · 5 comments
Closed

shadow does not work with 0.14.20 #822

totaam opened this issue Mar 12, 2015 · 5 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 12, 2015

Issue migrated from trac ticket # 822

component: server | priority: major | resolution: fixed

2015-03-12 02:27:07: floemker created the issue


With xpra 0.14.20 the shadow mode results in:

2015-03-11 20:43:16,449 server error processing new connection from Protocol(SocketConnection(/home/rvm/.xpra/ultra48-101-0)): calculate_workarea() takes exactly 1 argument (3 given)
Traceback (most recent call last):
  File "/RVM/lib/xpra/lib/python/xpra/server/server_core.py", line 462, in call_hello_oked
    self.hello_oked(proto, packet, c, auth_caps)
  File "/RVM/lib/xpra/lib/python/xpra/server/server_base.py", line 592, in hello_oked
    self.calculate_workarea(w, h)
TypeError: calculate_workarea() takes exactly 1 argument (3 given)

The attached patch seems to fix it for me. At least
"xpra shadow" starts again. I don't know if more is
needed.

@totaam
Copy link
Collaborator Author

totaam commented Mar 12, 2015

2015-03-12 02:27:46: floemker uploaded file xpra-0.14.20.patch (0.5 KiB)

@totaam
Copy link
Collaborator Author

totaam commented Mar 14, 2015

2015-03-14 03:39:24: totaam changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Mar 14, 2015

2015-03-14 03:39:24: totaam set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Mar 14, 2015

2015-03-14 03:39:24: totaam edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Mar 14, 2015

2015-03-14 03:39:24: totaam commented


Well, that's embarrassing, we should have caught that sooner! (added to #660)

Fix applied in 8777. Thanks!
(Even though this is am important fix, I may wait a few more days before releasing 0.14.21 because this is the only fix queued up so far..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant