Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Reload All Nodes #311

Merged
merged 1 commit into from
Mar 21, 2024
Merged

🐛 Fix Reload All Nodes #311

merged 1 commit into from
Mar 21, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

The reload all nodes function taps into reloading all nodes that were selected. This line was removed in a previous PR.

References

#296

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

1. Test All Nodes

  1. Open a canvas, ie ControlflowBranch.xircuits. Update one component (ie. adding a port to the Print component). Reload all nodes.
  2. Verify that all the modified nodes are updated.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/reload-all-fix

@MFA-X-AI MFA-X-AI merged commit 075b780 into master Mar 21, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/reload-all-fix branch March 21, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant