Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Frontend for Performance Improvements #320

Merged
merged 10 commits into from
May 2, 2024
Merged

Conversation

treo
Copy link
Contributor

@treo treo commented Apr 30, 2024

Description

This applies some changes to improve the performance of the Graph Renderer during interactions.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

1. See improvements

1. Open big file
2. move a node around
3. notice how things are kinda stuck until everything has caught up
4. apply PR
5. do the same, but notice that it isn't stuck for quite as long

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/paul/refactor-frontend

treo added 3 commits May 1, 2024 11:16
This removes the "PathFindingLinkFactory", which otherwise forces an unnecessary and expensive recalculation of connections that don't even exist.
@treo treo requested a review from MFA-X-AI May 1, 2024 10:17
@treo treo marked this pull request as ready for review May 1, 2024 10:17
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've noticed these changes:

  • when rendering the tooltip, if the comment has a scroll bar, the tooltip section will be less sharp.
    image

  • When you create a point, it will spawn the chain component interface.
    point spawn. I thought this was introduced in Click Link to Select, CTRL+Click to add a Point #319 but I tested it with the base xircuits, it didn't happen.

@treo treo changed the title WIP: Refactor Frontend for Performance Improvements Refactor Frontend for Performance Improvements May 2, 2024
@treo treo merged commit 23dcd63 into master May 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants