-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Frontend for Performance Improvements #320
Conversation
Update requirements.txt
Use a factory method to create Toolbar Buttons that will trigger a command.
This removes the "PathFindingLinkFactory", which otherwise forces an unnecessary and expensive recalculation of connections that don't even exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I've noticed these changes:
-
when rendering the tooltip, if the comment has a scroll bar, the tooltip section will be less sharp.
-
When you create a point, it will spawn the chain component interface.
. I thought this was introduced in Click Link to Select, CTRL+Click to add a Point #319 but I tested it with the base xircuits, it didn't happen.
Description
This applies some changes to improve the performance of the Graph Renderer during interactions.
Pull Request Type
Type of Change
Tests
1. See improvements
Tested on?