Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Any Argument general component #330

Merged
merged 1 commit into from
Jun 11, 2024
Merged

✨ Add Any Argument general component #330

merged 1 commit into from
Jun 11, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

This PR adds the any type argument to the general component list. This is particularly important for workflows that would like to accept arbitrary data to workflow components.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Drag in the Argument any component. Confirm that you can connect it with any ports, say with the Print component.
  2. Compile the workflow. Confirm it compiles without error. Verify that in the compiled script, the any port properly set as an InArg[any].
  3. Use the workflow as a workflow component. Confirm that you can arbitrary data to it by compiling and running it. Confirm that the output is as expected.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/any-args

@MFA-X-AI MFA-X-AI merged commit 8eec6c6 into master Jun 11, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/any-args branch June 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant