Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy & Paste support for Attached Literals #341

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

treo
Copy link
Contributor

@treo treo commented Jul 15, 2024

Description

In #340 we have added support for attached literals.

However, as @MFA-X-AI has pointed out, we didn't properly support copy & paste on them. Attached literals didn't get copied with the node they were attached to.

This PR adds this functionality.

References

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@treo treo requested a review from MFA-X-AI July 15, 2024 13:45
Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/paul/attach-literals-copy-paste

@MFA-X-AI MFA-X-AI merged commit b4dbe0b into master Jul 16, 2024
8 checks passed
@MFA-X-AI MFA-X-AI deleted the paul/attach-literals-copy-paste branch July 16, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants