Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify trojan transport & add ss2022 related config #465

Merged
merged 1 commit into from
Oct 4, 2023
Merged

feat: unify trojan transport & add ss2022 related config #465

merged 1 commit into from
Oct 4, 2023

Conversation

AutisticShark
Copy link
Contributor

No description provided.

@Septrum101 Septrum101 self-requested a review October 4, 2023 00:54
@Septrum101
Copy link
Contributor

Do you make any compatibility with old version?

@AutisticShark
Copy link
Contributor Author

mu_* options are for ShadowsocksR only and have been removed from sspanel a long time ago, considering XrayR no longer supports the SSR protocol it can be safely removed.

However, the method option is a new param used exclusively for the ss2022 server type, which will be available in the 2023.6 release.

The grpc param is created by XrayR's origin author, RManLuo, which is not consistent with the transport config of Vmess node type, this param will be dropped in 2023.6, operator of old version sspanel can update their custom config from "grpc": "1" to "network": "grpc" without breaking WebAPI compatibility.

@AutisticShark
Copy link
Contributor Author

AutisticShark commented Oct 4, 2023

And to be honest, XrayR should drop the legacy server config method, and bump the minimal sspanel compatibility level to 2021.11 or just add an OldSSPanel as a separate panel type, allowing the WebAPI adapter to follow upstream changes.

With more custom config related updates in the future and a versioned WebAPI feature level, there will be a limit when comes to maintaining compatibility with old and outdated versions of sspanel(especially those theme-based forks aka. Metron, Malio, etc.),

We will maintain a fork to include an updated WebAPI adapter and open pull requests if possible, however, it's up to you to decide if you want the maximum compatibility or follow the development of sspanel and make sure XrayR is usable for new installations.

The current stable release(0.9.0) has been broken since the last time we sunset a few legacy API endpoints, I have asked you multiple times to tag a new release, however, those comments are ignored. It's a shame we have to do the hard fork to fix a minor issue like this.

@Septrum101
Copy link
Contributor

Hello, @M1Screw ,you can pr a new sspanel api same like new v2board. Waiting for you good work.

@AutisticShark
Copy link
Contributor Author

AutisticShark commented Oct 4, 2023

Well, you can merge this one first, this includes changes that will come in the next stable release. Meanwhile please consider separating the custom config disabled/enabled sspanel type, we will make changes to the current sspanel panel type since it's not a complete redesign, unlike v2board's new API.

@Septrum101 Septrum101 merged commit 71aba06 into XrayR-project:master Oct 4, 2023
27 checks passed
@Septrum101
Copy link
Contributor

Thx for your pr. And I just optimise the determine of null custom_config. Could you test it works as expect?

@AutisticShark
Copy link
Contributor Author

Could you test it works as expect?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants