Require cmake minimum version 3.4 on all platforms #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the minimum required cmake to 3.4 on all platforms. Older cmake can be causing some problems without proper setting of cmake policies. For example, on macOS the variables
CMAKE_C_COMPILER_ID
andCMAKE_CXX_COMPILER_ID
are set toClang
instead ofAppleClang
.There are also a few minor whitespace changes for readability.
Closes #198