Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cmake option() for setting external parameters #202

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Use cmake option() for setting external parameters #202

merged 1 commit into from
Feb 8, 2020

Conversation

emmenlau
Copy link
Contributor

@emmenlau emmenlau commented Feb 7, 2020

This PR replaces the use of set() with option() to make sure users get the typical cmake behavior for setting external parameters. Additionally, this PR adds a default for cmake setting BUILD_SHARED_LIBS to ensure users build a shared library as before, as requested in #197

@zeyiwen
Copy link
Collaborator

zeyiwen commented Feb 8, 2020

Thanks @emmenlau

@zeyiwen zeyiwen merged commit b747745 into Xtra-Computing:master Feb 8, 2020
@emmenlau emmenlau deleted the use_cmake_options branch February 8, 2020 20:28
@emmenlau
Copy link
Contributor Author

emmenlau commented Feb 8, 2020

Glad that you like it! Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emmenlau @zeyiwen