Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build binaries for more python versions on linux #209

Merged
merged 2 commits into from
Mar 13, 2020
Merged

CI: build binaries for more python versions on linux #209

merged 2 commits into from
Mar 13, 2020

Conversation

guillaumedsde
Copy link
Contributor

@guillaumedsde guillaumedsde commented Mar 6, 2020

This PR only modifies the travis.yml but changes its structure significantly.

It uses the travis build configuration "matrix" to build ThunderSVM for Python versions 3.6, 3.7 and 3.8 for all CUDA versions and the CPU implementation only in linux (TravisCI does not support multiple python versions for MacOS and Windows very well).

It also makes use of YAML anchors to avoid some code repetition

note: since wheels are only published to github when a release is created, you can see what one would look like on my fork's release page

@zeyiwen
Copy link
Collaborator

zeyiwen commented Mar 11, 2020

Hi @guillaumedsde

The PR looks good. Thanks for your contribution. At the deploy section at the end of the new file, you have lines as follows.

   repo: guillaumedsde/thundersvm
   tags: true

Would you please revise or remove the link to your repo? I think this would help future maintenance.

@guillaumedsde
Copy link
Contributor Author

Hi, I removed the reference to my repo in commit 02966d8 🙂

@zeyiwen zeyiwen merged commit f604b42 into Xtra-Computing:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants