Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request/a9d0fc36 #45

Merged
merged 4 commits into from
Feb 13, 2018
Merged

Pull request/a9d0fc36 #45

merged 4 commits into from
Feb 13, 2018

Conversation

DavidBegert
Copy link
Contributor

JYTmv 12% speedup / 1.27% mem improv. Still much work to be done

@coveralls
Copy link

coveralls commented Feb 7, 2018 •
edited

Coverage Status

Coverage increased (+0.06%) to 78.156% when pulling a9d0fc3 on DavidBegert:pull-request/a9d0fc36 into 2a0cff9 on XtractOpen:dev.

jgranek
jgranek approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@jgranek jgranek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should revisit this and address David's TODO lines
(ie:

  • stabilize W in JTmv
  • look at efficiency in JthetaTmv
  • type stabilize a few more things to remove the need to assert types using lines like JYTmv 134: W::Array{T,2}=this.Q... etc.

@jgranek jgranek merged commit f50a3ce into XtractOpen:dev Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgranek jgranek jgranek approved these changes

Assignees

@jgranek jgranek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DavidBegert @coveralls @jgranek