Added batchNormLayerNN to replace NN #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
lruthotto
approved these changes
Feb 9, 2018
|
I think that this separation is a very good idea
E
… On Feb 9, 2018, at 11:47 AM, Lars Ruthotto ***@***.***> wrote:
Looks good to me
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
klensink
reviewed
Feb 9, 2018
| tmp[1,1] = Y0 | ||
| end | ||
|
|
||
| Ydata::Array{T,2} = zeros(T,0,nex) |
There was a problem hiding this comment.
Instead of initializing with 0 rows, you could init it with with how many non zero entries there are in this.outTimes, then the data is pre allocated and you just need to store into it
| nex = div(length(Y),nFeatIn(this)) | ||
| nt = length(this.layers) | ||
| cnt = 0 | ||
| dYdata = zeros(T,0,nex) |
| dY = 0*Y | ||
| end | ||
|
|
||
| dYdata = zeros(T,0,nex) |
| for i=nt:-1:1 | ||
| if this.outTimes[i]==1 | ||
| nn = nFeatOut(this.layers[i]) | ||
| W += this.Q'*Wdata[end-cnt2-nn+1:end-cnt2,:] |
There was a problem hiding this comment.
Depending on how big this sub array is, it might be worth using a @view to avoid the allocation
There was a problem hiding this comment.
These are all things that are also in NN so lets put this on the TODO list and make the changes together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it much easier to debug and there are probably some optimizations we can do since we know exactly what is contained in batchNormLayerNNs layers