Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for AWS_EC2_METADATA_DISABLED env var #380

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat: Add support for AWS_EC2_METADATA_DISABLED env var #380

merged 1 commit into from
Nov 14, 2023

Conversation

messense
Copy link
Contributor

@messense
Copy link
Contributor Author

Not sure if this is the right place to add it, maybe a new field in Config is better?

@Xuanwo
Copy link
Owner

Xuanwo commented Nov 13, 2023

Not sure if this is the right place to add it, maybe a new field in Config is better?

Yep, I think we should read this value from config.

Copy link
Owner

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo changed the title Add support for AWS_EC2_METADATA_DISABLED env var feat: Add support for AWS_EC2_METADATA_DISABLED env var Nov 14, 2023
@Xuanwo Xuanwo merged commit 4d75451 into Xuanwo:main Nov 14, 2023
11 checks passed
@messense messense deleted the aws-ec2-metadata-disabled branch November 14, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants