Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for username stripping #80

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

atemp
Copy link

@atemp atemp commented Oct 5, 2020

Many people use space to wakeup display from screensaver, so it happens that they end up having one space in front of their username in greeter. They will then get an incorrect password message even and trying it again won't help, because they only reenter their password instead of double checking the username. One leading space is hard to spot, since the password field at least looks to have more space before the first circle.

This pull request adds a config option username-strip-whitespace.

@ochosi
Copy link
Collaborator

ochosi commented Oct 25, 2021

While this sounds like a usability improvement I would personally not make this an option. Either the greeter behaves this way or not.
I don't think having a space in the username is even possible, so this should just happen unconditionally by default.

Copy link
Author

@atemp atemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, that makes PR smaller and i agree, that it should never hurt

@bluesabre
Copy link
Member

Nice and tidy. Thanks for the patch and discussions!

@bluesabre bluesabre merged commit 59fb38a into Xubuntu:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants