Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Ability to disable whitelisting feature through config. #167

Closed
2 tasks done
SurroundedByThings opened this issue Jul 12, 2023 · 7 comments
Closed
2 tasks done
Labels
enhancement New feature or request

Comments

@SurroundedByThings
Copy link

SurroundedByThings commented Jul 12, 2023

Checks

Description

Option in the config to make players who are not admins unable to add people to the whitelist. By admins I mean the ones who are added in the config file.

@SurroundedByThings SurroundedByThings added the enhancement New feature or request label Jul 12, 2023
@Xujiayao
Copy link
Owner

Xujiayao commented Aug 9, 2023

A rewrite of lang file is required to implement dynamic permission of /whitelist command, please wait.

Xujiayao added a commit that referenced this issue Aug 9, 2023
@Xujiayao
Copy link
Owner

Xujiayao commented Aug 9, 2023

Hi. U may use the latest build.

@tstoco
Copy link

tstoco commented Aug 28, 2023

Hiya,

This feature is not in the documentation, is it?

@tstoco
Copy link

tstoco commented Aug 28, 2023

Also, I have noticed that if you add whitelistRequiresAdmin: true to the generic object in the config file. It is deleted when the server is restarted and users without Admin rights can manage the whitelist.

A workaround this issue, was to under Server>Integration restrict the use of the command to Roles/Users as desired.

@Xujiayao
Copy link
Owner

Hiya,

This feature is not in the documentation, is it?

Ofc. This fix is not even released!

@Xujiayao
Copy link
Owner

Xujiayao commented Aug 28, 2023

Also, I have noticed that if you add whitelistRequiresAdmin: true to the generic object in the config file. It is deleted when the server is restarted and users without Admin rights can manage the whitelist.

Once again, the same problem as above. You MUST use the latest build, which includes this fix. The latest build version will auto-generate this config item. Manually adding an unknown item to the config file is not readable by the current 2.2.0 release!

A workaround this issue, was to under Server>Integration restrict the use of the command to Roles/Users as desired.

And you do not need to use this method once you use the latest build. (You can still do it. It is up to you.)

@tstoco
Copy link

tstoco commented Aug 28, 2023

Thanks for the clarification.

I mixed latest build with latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants