[Bug] fix JDA hangs ~10 min on server stop

[Clem-Fern]

Checks

• I confirm that I have searched for existing issues / pull requests before requesting to avoid duplicate requesting.
• I confirm that I noted that if I don't follow the instructions, the issue may be closed directly.

Description

Hi @Xujiayao, hope you're doing well.

Because of the activation of the udpateTopic feature and in some case, the JVM is kept running several minutes after the server has stopped. There's absolutely no log from the mod when the problem occurs.

It seems to be cause by the high rate limit on the discord endpoint api used to update a channel's topic and the fact that MCDC wait for the update to be complete before shutting down the JDA instance. (after quick research, same problem encountered on some other discord integration mod/plugin)

In this fix, the topic update is queued and the mod does not wait anymore for the completion of the future. I also explicitly terminated the HTTPClient instance used by JDA to be sure that, in any case, it will not kept the JVM running after the shutdown. (JDA Doc)

I think there's not over way to avoid this issue due to the discord endpoint rate limit. We could probably add a new config key to let the user free to decide if he wants the server to wait the topic update before shutting down or not.

I hope i didn't miss anything... Feel free to ask if any change need :)

[Xujiayao]

It seems to be cause by the high rate limit on the discord endpoint api used to update a channel's topic and the fact that MCDC wait for the update to be complete before shutting down the JDA instance.

This is intentional. MCDC waits until the channel topic is updated to "Server offline", otherwise the channel topic keep showing that the server is online, which is unsatisfactory.

[Clem-Fern]

well yeah, that's what i thought. Hence my proposition to add a new configuration to volontary ignore the discord rate limit on the topic's update. That would be a good compromise to avoid this issue without having to totaly disabling the topic feature.

[Xujiayao]

Thank you for your contribution!