Skip to content

Commit

Permalink
remove empty route error check in auth xds logic (envoyproxy#1019)
Browse files Browse the repository at this point in the history
the Xds translator should not error out when the IR routes
are empty

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
  • Loading branch information
arkodg committed Feb 9, 2023
1 parent 38a6ddd commit 821b7d5
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions internal/xds/translator/authentication.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ func patchHCMWithJwtAuthnFilter(mgr *hcm.HttpConnectionManager, irListener *ir.H
return errors.New("ir listener is nil")
}

if len(irListener.Routes) == 0 {
return errors.New("ir listener contains no routes")
}

if !listenerContainsJwtAuthn(irListener) {
return nil
}
Expand Down

0 comments on commit 821b7d5

Please sign in to comment.