-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media variants support #58
Media variants support #58
Conversation
Looks good to me, however I don't have access to Twitter API anymore to test I don't remember if you still have it @marcogruhl ? |
This fix is already running on our prod, so I think it may be considered as tested |
@lutsenkirill thank you for your PR. It also looks good to me. But i only have the nearly useless free tier left, so i also could not test your changes. |
@marcogruhl sure, will try to make it this week, and test the rest of the tests as well |
@marcogruhl @Xwilarg regarding existing tests: most of them work fine, but some fail. This is screenshot with failing ones: Also attach this list in file: Note that |
@marcogruhl done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I can't test but overall it looks good for me, if it's good with marco I think we can merge it
Like I said, i dont know an other way how to keep this repo alive then depending on tests/subscriptions from others. so I send it. |
@Xwilarg @marcogruhl thank you! Is there any chance to publish new version today? I guess you need to fix CI/CD pipeline to make it ignore falling tests |
Support of Twitter media variants
https://developer.twitter.com/en/docs/twitter-api/data-dictionary/object-model/media
It is required, for example, if one needs to obtain url to the video