Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media variants support #58

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

lutsenkirill
Copy link
Contributor

@lutsenkirill lutsenkirill commented Aug 8, 2023

Support of Twitter media variants
https://developer.twitter.com/en/docs/twitter-api/data-dictionary/object-model/media

It is required, for example, if one needs to obtain url to the video

@Xwilarg Xwilarg requested a review from marcogruhl August 9, 2023 08:01
@Xwilarg
Copy link
Owner

Xwilarg commented Aug 9, 2023

Looks good to me, however I don't have access to Twitter API anymore to test

I don't remember if you still have it @marcogruhl ?

@lutsenkirill
Copy link
Contributor Author

Looks good to me, however I don't have access to Twitter API anymore to test

I don't remember if you still have it @marcogruhl ?

This fix is already running on our prod, so I think it may be considered as tested

@marcogruhl
Copy link
Collaborator

@lutsenkirill thank you for your PR. It also looks good to me. But i only have the nearly useless free tier left, so i also could not test your changes.
Could you please write at least one test? The API changes so quickly, so this would help to find issues if they are in that part.
PS: Do you have the Pro access level for running all tests? And do they still run?

@lutsenkirill
Copy link
Contributor Author

@marcogruhl sure, will try to make it this week, and test the rest of the tests as well

@lutsenkirill
Copy link
Contributor Author

lutsenkirill commented Aug 15, 2023

@marcogruhl @Xwilarg regarding existing tests: most of them work fine, but some fail.

This is screenshot with failing ones:

image

Also attach this list in file:
failed_tests.txt

Note that TestFollow tests failed because of limitation of our subscription, so idk if they works

@lutsenkirill
Copy link
Contributor Author

@marcogruhl done

Copy link
Owner

@Xwilarg Xwilarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I can't test but overall it looks good for me, if it's good with marco I think we can merge it

@marcogruhl
Copy link
Collaborator

marcogruhl commented Aug 15, 2023

Like I said, i dont know an other way how to keep this repo alive then depending on tests/subscriptions from others. so I send it.
Thank you for taking part in this project!

@marcogruhl marcogruhl merged commit 6985407 into Xwilarg:master Aug 15, 2023
1 check failed
@lutsenkirill
Copy link
Contributor Author

@Xwilarg @marcogruhl thank you! Is there any chance to publish new version today? I guess you need to fix CI/CD pipeline to make it ignore falling tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants