Skip to content
This repository has been archived by the owner on Oct 14, 2019. It is now read-only.

Commit

Permalink
Fix crash and problems with "I want to schedule an event"
Browse files Browse the repository at this point in the history 
Also right now it only picks out the words I, want, and schedule (for some reason doesn't pick out event), I can fix that if you need
  • Loading branch information
@jacob1
jacob1 committed Dec 4, 2015
1 parent bbbc20c commit 6368b64
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CoreNLP.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def ConfirmVerb(parsed, verb):
otherThing = FindDependency(parsed, newverbcheck, "advmod")
if otherThing:
return otherThing, newverbcheck
return verb
return None, None

# This function searches "deps_basic" to find relationships between words
# It is passed in the position of the word(s) that we relationship is on
Expand Down

2 comments on commit 6368b64

@Xyaneon
Copy link
Owner

@Xyaneon Xyaneon commented on 6368b64 Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least it doesn't crash now. This is a special case that should trigger the assistant to run process_add_cal_event() eventually.

@jacob1
Copy link
Contributor Author

@jacob1 jacob1 commented on 6368b64 Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if I fix the parsing to recognize "schedule" as the alternate verb and "event" as the alternate noun then it should all be fine. Right now it says schedule is a noun .. although I think that is my fault since the corenlp is clearly saying it is a verb.

I prefer to do things through corenlp when possible, but I guess we could just special case it for the demo if we need.

Please sign in to comment.