-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow UI settings to persist #21
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @Xyphyn on Vercel. @Xyphyn first needs to authorize it. |
I'm unsure why I even have this mergeObjects function as a simple { ...obj1, ...obj2 } would probably work |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The issue you're stating only seems to occur on some settings. I assume it's not saving actually, could you check local storage after you change a setting? |
I did check the local storage and it was updating there. The issue appears to have been the mergeObjects function, which was overwriting the stored values. |
UI settings were being overwritten on refresh. Changing this check appears to resolve this issue and allows for the UI settings to persist.
8f59753
to
9fb5460
Compare
I've updated the PR to remove the I tested it briefly and this appears to work fine for allowing settings to persist. |
This works! Thanks for your contribution! |
UI settings were being overwritten on refresh. Changing this check appears to resolve this issue and allows for the UI settings to persist.
UI settings were being overwritten on refresh. Changing this check appears to resolve this issue and allows for the UI settings to persist.