Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to hide deleted or removed posts #71

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

pbui
Copy link
Contributor

@pbui pbui commented Aug 5, 2023

Add hidePosts.{deleted,removed} settings to control whether or not to display posts that have been marked as deleted or removed. By default, these are enabled (ie. hidden) to correspond to Lemmy-UI behavior.

Currently, this change only hides these posts for the front page and community pages.

Before these settings are introduced, you can see all posts regardless of if they are deleted or removed:

Screenshot from 2023-08-05 13-58-31

After these changes, you can hide both removed and deleted:

Screenshot from 2023-08-05 14-32-31

Or just hide deleted:

Screenshot from 2023-08-05 14-33-03

Or just hide the removed:

Screenshot from 2023-08-05 14-32-47

Add hidePosts.{deleted,removed} settings to control whether or not to
display posts that have been marked as deleted or removed.  By default,
these are enabled (ie. hidden) to correspond to Lemmy-UI behavior.

Currently, we only hide these posts for the front page and community
pages.
@vercel
Copy link

vercel bot commented Aug 5, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Xyphyn on Vercel.

@Xyphyn first needs to authorize it.

Copy link
Owner

@Xyphyn Xyphyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xyphyn
Copy link
Owner

Xyphyn commented Aug 5, 2023

Although maybe the default should be changed to false because otherwise it may confuse some mods that haven't seen the option before.

@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
photon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2023 6:44pm

@Xyphyn
Copy link
Owner

Xyphyn commented Aug 5, 2023

Changed the default for removed to true, as mods likely need it by default

@Xyphyn Xyphyn merged commit 85468a5 into Xyphyn:main Aug 5, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants