Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lfkdsk/refinements code and add test #50

Merged
merged 6 commits into from
Oct 13, 2018
Merged

Conversation

lfkdsk
Copy link
Member

@lfkdsk lfkdsk commented Oct 9, 2018

No description provided.

@lfkdsk lfkdsk requested a review from thautwarm October 9, 2018 17:08
@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #50 into master will increase coverage by 0.28%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   80.35%   80.64%   +0.28%     
==========================================
  Files          19       19              
  Lines        1792     1793       +1     
  Branches      326      326              
==========================================
+ Hits         1440     1446       +6     
+ Misses        266      261       -5     
  Partials       86       86

* push
* reset test command and fix bug
* fix test
* fix test
* add test
* add py file test
@coveralls
Copy link

coveralls commented Oct 10, 2018

Pull Request Test Coverage Report for Build 126

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • 38 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.6%) to 83.436%

Files with Coverage Reduction New Missed Lines %
yapypy/extended_python/emit_impl/simple_stmt.py 1 94.2%
yapypy/extended_python/emit_impl/simple_expr.py 1 91.94%
yapypy/extended_python/emit_impl/comprehensions.py 36 94.23%
Totals Coverage Status
Change from base Build 124: 0.6%
Covered Lines: 1496
Relevant Lines: 1793

💛 - Coveralls

@lfkdsk
Copy link
Member Author

lfkdsk commented Oct 10, 2018

元循环做编译时错误检查,coverage 还是统计不到,可能以后 test 要手动控制 coverage.py 的 API.

@lfkdsk lfkdsk merged commit 892693b into master Oct 13, 2018
@lfkdsk lfkdsk deleted the lfkdsk/refinements-code branch October 15, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants