Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #167

Merged
merged 3 commits into from
Apr 3, 2022
Merged

Small fixes #167

merged 3 commits into from
Apr 3, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Apr 3, 2022

Purpose

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt added enhancement New feature devops DevOps tasks labels Apr 3, 2022
@MBkkt MBkkt requested a review from kononovk as a code owner April 3, 2022 07:55
@MBkkt MBkkt changed the title Mbkkt/another try Small fixes Apr 3, 2022
@MBkkt MBkkt force-pushed the mbkkt/another-try branch 6 times, most recently from 5f08e5f to 52e57cc Compare April 3, 2022 12:05
@coveralls
Copy link

coveralls commented Apr 3, 2022

Pull Request Test Coverage Report for Build 2085314280

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 100.0%

Totals Coverage Status
Change from base Build 2083091196: 0.09%
Covered Lines: 1069
Relevant Lines: 1069

💛 - Coveralls

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #167 (5715388) into main (af2e09c) will increase coverage by 3.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   91.69%   95.22%   +3.53%     
==========================================
  Files          50       49       -1     
  Lines        1084     1069      -15     
  Branches      164      125      -39     
==========================================
+ Hits          994     1018      +24     
+ Misses          1        0       -1     
+ Partials       89       51      -38     
Impacted Files Coverage Δ
include/yaclib/algo/detail/wait_impl.hpp 80.00% <ø> (+8.12%) ⬆️
src/log_error.cpp 100.00% <ø> (ø)
src/log_info.cpp 100.00% <ø> (ø)
include/yaclib/async/future.hpp 100.00% <100.00%> (+14.28%) ⬆️
include/yaclib/util/detail/safe_call.hpp 75.00% <0.00%> (-12.50%) ⬇️
include/yaclib/async/detail/result_core.hpp 96.66% <0.00%> (-0.21%) ⬇️
include/yaclib/async/detail/future_impl.hpp 90.56% <0.00%> (-0.09%) ⬇️
include/yaclib/util/result.hpp 100.00% <0.00%> (ø)
... and 20 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@MBkkt MBkkt merged commit ca98029 into main Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps tasks enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants