Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutex for coroutines #177

Merged
merged 45 commits into from
Jun 4, 2022
Merged

Mutex for coroutines #177

merged 45 commits into from
Jun 4, 2022

Conversation

mkornaukhov03
Copy link
Member

No description provided.

@mkornaukhov03 mkornaukhov03 requested a review from MBkkt as a code owner May 6, 2022 00:07
Copy link
Member

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 11, 2022

Pull Request Test Coverage Report for Build 2437598382

  • 111 of 111 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2271835310: 0.0%
Covered Lines: 1249
Relevant Lines: 1249

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #177 (63556f9) into main (511109c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #177    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           51        54     +3     
  Lines         1138      1249   +111     
==========================================
+ Hits          1138      1249   +111     
Impacted Files Coverage Δ
include/yaclib/async/detail/base_core.hpp 100.00% <100.00%> (ø)
include/yaclib/coroutine/async_mutex.hpp 100.00% <100.00%> (ø)
include/yaclib/coroutine/detail/promise_type.hpp 100.00% <100.00%> (ø)
src/executor/manual.cpp 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mkornaukhov03 mkornaukhov03 assigned MBkkt and unassigned MBkkt May 15, 2022
Copy link
Member

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need more powerful tests
Also please don't forget about noexcept, final, nodiscard

include/yaclib/coroutine/async_mutex.hpp Show resolved Hide resolved
cmake/yaclib_coro.cmake Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
test/unit/coroutine/async_mutex.cpp Outdated Show resolved Hide resolved
test/unit/coroutine/async_mutex.cpp Show resolved Hide resolved
test/unit/coroutine/async_mutex.cpp Outdated Show resolved Hide resolved
test/unit/coroutine/async_mutex.cpp Show resolved Hide resolved
test/unit/coroutine/async_mutex.cpp Show resolved Hide resolved
include/yaclib/coroutine/detail/promise_type.hpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/coroutine.hpp Outdated Show resolved Hide resolved
src/config.hpp.in Outdated Show resolved Hide resolved
include/yaclib/coroutine/async_mutex.hpp Outdated Show resolved Hide resolved
test/unit/coroutine/async_mutex.cpp Outdated Show resolved Hide resolved
include/yaclib/coroutine/coroutine.hpp Outdated Show resolved Hide resolved
@mkornaukhov03 mkornaukhov03 assigned MBkkt and unassigned MBkkt Jun 3, 2022
@MBkkt MBkkt merged commit 8866c1c into main Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants