-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few improvements #186
Merged
Merged
Few improvements #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add return_value(FutureBase<V, E>&& f), that allow to return value from future with same type as coroutine more free than co_return co_await f; * Add return_value(StopTag) for cancel coroutine Future from function/Promise side * Add ability to return error or result from coroutine Future * Replace return_void with return_value(Unit) and co_return; with co_return {}; for allow use other return_value(...) in void coroutine
* Remove WaitGroup and AwaitGroup duplication * Make WaitGroup and OneShotEvent better * Make Wait single Future faster
kononovk
previously approved these changes
Aug 6, 2022
MBkkt
commented
Aug 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 55 -5
Lines 1361 1303 -58
=========================================
- Hits 1361 1303 -58
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
79b72cb
to
b9d9891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Few fixes for coroutine:
Add return_value(FutureBase<V, E>&& f), that allow to return value from future with same type as coroutine more free than co_return co_await f;Fix BaseCore possible bug with incorrect static_cast ...
Few wait* fixes:
Related Information
Testing