Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #191

Merged
merged 5 commits into from
Aug 7, 2022
Merged

Update README.md #191

merged 5 commits into from
Aug 7, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Aug 7, 2022

Purpose

Please use labels for this PR

Please describe the changes in this PR for reviewers

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

kononovk
kononovk previously approved these changes Aug 7, 2022
README.md Outdated Show resolved Hide resolved
README.md Outdated
## Contacts
## Thanks

* [Roman Lipovsky](https://gitlab.com/Lipovsky) for an incredible [course about concurrency](https://gitlab.com/Lipovsky/concurrency-course), which gave me a lot of ideas for this library and for showing me how and how important it is to test concurrency correctly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Roman Lipovsky](https://gitlab.com/Lipovsky) for an incredible [course about concurrency](https://gitlab.com/Lipovsky/concurrency-course), which gave me a lot of ideas for this library and for showing me how and how important it is to test concurrency correctly.
* [Roman Lipovsky](https://gitlab.com/Lipovsky) for an incredible [course about concurrency](https://gitlab.com/Lipovsky/concurrency-course), which gave us a lot of ideas for this library and for showing us how important it is to test concurrency correctly.

README.md Outdated Show resolved Hide resolved
MBkkt and others added 2 commits August 7, 2022 16:03
Co-authored-by: Kononov Nikolay <kononov.nikolay.nk1@gmail.com>
@MBkkt MBkkt merged commit 8e446ed into main Aug 7, 2022
Copy link
Member

@kononovk kononovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@MBkkt MBkkt deleted the update_readme branch September 18, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants