Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make better #219

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Make better #219

merged 4 commits into from
Oct 20, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Oct 20, 2022

Purpose

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt requested a review from kononovk as a code owner October 20, 2022 04:33
@coveralls
Copy link

coveralls commented Oct 20, 2022

Pull Request Test Coverage Report for Build 3287398286

  • 82 of 82 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3277731291: 0.0%
Covered Lines: 1368
Relevant Lines: 1368

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #219 (6491f2b) into main (2aefe08) will decrease coverage by 0.14%.
The diff coverage is 97.53%.

❗ Current head 6491f2b differs from pull request most recent head 7bb89bb. Consider uploading reports for the commit 7bb89bb to get more accurate results

@@             Coverage Diff             @@
##              main     #219      +/-   ##
===========================================
- Coverage   100.00%   99.85%   -0.15%     
===========================================
  Files           62       62              
  Lines         1358     1369      +11     
===========================================
+ Hits          1358     1367       +9     
- Misses           0        2       +2     
Impacted Files Coverage Δ
include/yaclib/async/detail/when_any_impl.hpp 97.36% <96.22%> (-2.64%) ⬇️
include/yaclib/algo/detail/core.hpp 100.00% <100.00%> (ø)
include/yaclib/async/detail/when_all_impl.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt MBkkt added the performance Improve performance label Oct 20, 2022
@MBkkt MBkkt self-assigned this Oct 20, 2022
* Make deallocation faster
* Fix data race for Future<bool> that can be caused by std::vector<bool>
* Remove unnecessary checks and fields for with None policy
* Remove unnecessary synchronization in dtor
* Make faster deallocation
* FirstFail policy implemented without additional move/etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants