Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #231

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix CI #231

merged 1 commit into from
Jan 12, 2023

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Jan 12, 2023 •
edited
Loading

Purpose

  • ubuntu now missing libclang-rt-14-dev package which needs for clang with sanitizers
  • brew on macOS 12 cannot install old llvm because update deps
  • remove useless codeball action
  • Use lld-14 on linux for linking, it makes build a little faster

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt requested a review from kononovk as a code owner January 12, 2023 16:39
@MBkkt MBkkt assigned MBkkt and unassigned MBkkt Jan 12, 2023
@MBkkt MBkkt force-pushed the fix-ci branch 2 times, most recently from bb22a50 to fa8f3df Compare January 12, 2023 18:03
kononovk
kononovk approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@kononovk kononovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MBkkt MBkkt merged commit 75354f9 into main Jan 12, 2023
@MBkkt MBkkt deleted the fix-ci branch December 7, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovk kononovk kononovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MBkkt @kononovk